Fix: Add better separator for hosts to avoid host skipping.#32
Open
stefaro wants to merge 2 commits intosunlei:masterfrom
Open
Fix: Add better separator for hosts to avoid host skipping.#32stefaro wants to merge 2 commits intosunlei:masterfrom
stefaro wants to merge 2 commits intosunlei:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found that this was skipping some hosts configurations that I had (i have ~300 hosts) .
By making record separator more specific I got it working in a more reliable way.
Separating records by
@@before each host declaration seems to work nicely and it AFAIK shouldn't collide with any other configuration thing easily. For modifiying the ssh_configuration i used sed with regexs/[ \t]*host, which should make the addition safely and in at least realitvely compatible way for different sed implementations.